Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export jl_setjmp on Windows #45309

Closed
wants to merge 1 commit into from
Closed

Export jl_setjmp on Windows #45309

wants to merge 1 commit into from

Conversation

Taaitaaiger
Copy link
Contributor

@Taaitaaiger Taaitaaiger commented May 13, 2022 •
edited
Loading

This PR exports jl_setjmp on Windows. It's based on #42267. Fixes #43340.

@vchuravy vchuravy requested a review from KristofferC May 13, 2022 21:57
@Taaitaaiger
Copy link
Contributor Author

I don't know how to solve the compilation error that is triggered (due to duplicate definitions of jl_setjmp). If I understand what's going on correctly, the definitions in _setjmp.winX.S clash with the export inserted by JL_EXPORTED_FUNCS_WIN(XX) in trampolines_X.S. I think it might be solved with the changes from #42151 which mentions #42267

@ViralBShah ViralBShah added the system:windows Affects only Windows label May 15, 2022
@ViralBShah ViralBShah added the backport 1.6 Change should be backported to release-1.6 label Nov 2, 2023
@ViralBShah ViralBShah added this to the 1.6.x milestone Nov 2, 2023
@ViralBShah
Copy link
Member

Realistically, we are unlikely to make new 1.6 releases now - so perhaps we should close.

@Taaitaaiger
Copy link
Contributor Author

That's fine by me. Does that mean 1.10 will be the next LTS, or am I misinterpreting things?

@ViralBShah
Copy link
Member

ViralBShah commented Nov 3, 2023 •
edited
Loading

That's fine by me. Does that mean 1.10 will be the next LTS, or am I misinterpreting things?

I believe that decision cannot be taken until 1.10 is out and we are closer to 1.11. Please don't treat either of my statements as official. Just observations on my part.

@vtjnash vtjnash closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 system:windows Affects only Windows
Projects
None yet
Milestone
1.6.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Taaitaaiger @ViralBShah @vtjnash @JeffBezanson