[src] Silence GCC 12 warnings about dangling pointers #45617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different compilers
Using `-Wno-pragmas` would still cause issues when building with `-Werror`.
giordano
force-pushed
the
mg/ignore-dangling-pointers
branch
from
5fdf8d1 to
78e3e57
Compare
|
Bump 🙂 I'll merge by the end of the week if there are no objections. |
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
* [src] Silence GCC 12 warnings about dangling pointers * [src] Compile with `-Wno-pragmas` to allow pragrams accepted only by different compilers * [src] Use pragma only when relevant (GCC >= 12) Using `-Wno-pragmas` would still cause issues when building with `-Werror`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 12 introduced some new warnings (ref: #45400). This PR silence some of them, my understanding is that the dangling pointers are used on purpose here. If not, this should be resolved in some other ways.