Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #45825, BitArray methods assuming 1-indexing of AbstractArray #45835

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix #45825, BitArray methods assuming 1-indexing of AbstractArray #45835

merged 1 commit into from
Jul 18, 2022

Conversation

JeffBezanson
Copy link
Sponsor Member

fix #45825

@JeffBezanson JeffBezanson added arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug labels Jun 27, 2022
@vchuravy vchuravy added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 labels Jun 27, 2022
N5N3
N5N3 reviewed Jun 28, 2022
View reviewed changes
base/bitarray.jl Outdated Show resolved Hide resolved
@martinholters
Copy link
Member

Might be too breaking before 2.0, but shouldn't BitArray(::OffsetArray) throw just like Array{Bool}(::OffsetArray) does (unless the start index happens to be 1)?

@JeffBezanson
Copy link
Sponsor Member Author

Oh I see, I was just wrong about what behavior is intended then. I was thinking of the argument as an iterator.

@JeffBezanson
Copy link
Sponsor Member Author

Ok this should be right now. Using nextind seems to give full performance.

N5N3
N5N3 reviewed Jun 30, 2022
View reviewed changes
base/bitarray.jl Outdated Show resolved Hide resolved
This was referenced Jul 5, 2022
Merged
Merged
@KristofferC KristofferC mentioned this pull request Jul 17, 2022
Merged
32 tasks
@JeffBezanson JeffBezanson merged commit 820c08b into master Jul 18, 2022
@JeffBezanson JeffBezanson deleted the jb/fix45825 branch July 18, 2022 19:02
KristofferC pushed a commit that referenced this pull request Jul 20, 2022
@JeffBezanson
fix #45825, BitArray methods assuming 1-indexing of AbstractArray (#4…
9fa6b7f 
…5835)

(cherry picked from commit 820c08b)
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Open
78 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
@JeffBezanson
fix JuliaLang#45825, BitArray methods assuming 1-indexing of Abstract…
11225cd 
…Array (JuliaLang#45835)
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@JeffBezanson @pcjentsch
fix JuliaLang#45825, BitArray methods assuming 1-indexing of Abstract…
9254de7 
…Array (JuliaLang#45835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N5N3 N5N3 N5N3 left review comments

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
5 participants
@JeffBezanson @martinholters @N5N3 @vchuravy @KristofferC