Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic imshow and working ppmwrite #459

Merged
merged 2 commits into from
Feb 24, 2012
Merged

basic imshow and working ppmwrite #459

merged 2 commits into from
Feb 24, 2012

Conversation

stefan-k
Copy link
Contributor

ppmwrite now writes all channels to disk, not just the blue channel.
The imshow function is really very basic: It writes the image to disk and shows it using feh.

The previous version just wrote the blue channel to the file.
The function writes the image on disk using ppmwrite and then shows the
image using feh. Therefore depends on having feh installed. I guess it's
sufficient for testing purposes.
@JeffBezanson
Copy link
Member

This is only "proper" depending on how your image is stored ;)
I was using pixels packed into int32s. But, I'm fine with switching to this convention.
Maybe ideally we'd have overloads for 3-d int8 arrays vs. 2-d int32 arrays.
As for feh, this stuff is not an official library yet, so it doesn't matter. Might as well take it.

@stefan-k
Copy link
Contributor Author

Ah, now I understand why this wasn't working. I read an image using imread and then saved with ppmwrite which didn't work.
I'm about to implement some other basic functions, just to get a minimal image processing environment. I hope this is ok (I don't want to annoy you guys since you probably have more important stuff to do ;)).

@JeffBezanson
Copy link
Member

Sounds great. Since it's in examples/, you can go nuts with it.
If you're planning to write particular matlab functions, could you label yourself as the author in the spreadsheet viral sent out?

JeffBezanson added a commit that referenced this pull request Feb 24, 2012
basic imshow and working ppmwrite
@JeffBezanson JeffBezanson merged commit 382927e into JuliaLang:master Feb 24, 2012
@stefan-k
Copy link
Contributor Author

Sure! But my functions will (for now) just cover basic functionality, nowhere near what the Matlab functions are capable of. Should I still label myself als author?

@JeffBezanson
Copy link
Member

If you implement a subset of a matlab function, yes. Personally I'd prefer most of those functions to be simpler, and either be split into multiple functions or just have fewer features period. I hate seeing y = foo(x, z); and wondering which of 100 possible things it's doing :)
We're not a matlab clone, so we only follow matlab names and behaviors where it obviously makes sense, like fft(x).

StefanKarpinski pushed a commit that referenced this pull request Feb 8, 2018
cmcaine pushed a commit to cmcaine/julia that referenced this pull request Nov 11, 2022
Keno pushed a commit that referenced this pull request Oct 9, 2023
This has an llvmcall doing an atomic operation...just avoid the hassle
and call it directly.

Fixes #354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants