-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic imshow and working ppmwrite #459
Conversation
The previous version just wrote the blue channel to the file.
The function writes the image on disk using ppmwrite and then shows the image using feh. Therefore depends on having feh installed. I guess it's sufficient for testing purposes.
This is only "proper" depending on how your image is stored ;) |
Ah, now I understand why this wasn't working. I read an image using imread and then saved with ppmwrite which didn't work. |
Sounds great. Since it's in |
basic imshow and working ppmwrite
Sure! But my functions will (for now) just cover basic functionality, nowhere near what the Matlab functions are capable of. Should I still label myself als author? |
If you implement a subset of a matlab function, yes. Personally I'd prefer most of those functions to be simpler, and either be split into multiple functions or just have fewer features period. I hate seeing |
This has an llvmcall doing an atomic operation...just avoid the hassle and call it directly. Fixes #354
ppmwrite now writes all channels to disk, not just the blue channel.
The imshow function is really very basic: It writes the image to disk and shows it using feh.