-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rem2pi for non-finite arguments #46163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followup to https://github.com/JuliaLang/julia/pull/36420/files that fixes `Inf` and `-Inf` as well (and I believe at slightly lower cost)
We also should really make better implimentations of |
giordano
reviewed
Jul 25, 2022
giordano
reviewed
Jul 25, 2022
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Merged
oscardssmith
added
backport 1.6
Change should be backported to release-1.6
backport 1.7
backport 1.8
Change should be backported to release-1.8
labels
Jul 25, 2022
ready to merge? |
Use |
good point. |
Closed
32 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 7, 2022
(cherry picked from commit 73c1eeb)
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 73c1eeb)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 73c1eeb)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 73c1eeb)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 73c1eeb)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 73c1eeb)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 73c1eeb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #36420 that fixes
Inf
and-Inf
as well (and I believe at slightly lower cost)