Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGit2: correct regex for credential helpers #46597

Merged
merged 1 commit into from
Sep 6, 2022

Commits on Sep 6, 2022

  1. LibGit2: correct regex for credential helpers

    The previous regex for credential helpers included even the following
    credential:
    
    ```
    [credential "helperselector"]
        selected = manager-core
    ```
    
    which gets introduced by Git for Windows and fails our assumption about
    what a credential helper is.
    
    The commit also removes a test that mirrors what `credential_helpers`
    does (otherwise, we would have to maintain the same regex at two places,
    the definition of `credential_helpers` and the test case).
    
    Fixes JuliaLang#45693
    barucden committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0280c0a View commit details
    Browse the repository at this point in the history