Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MSYS2's path munging for stringreplace #46803

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Commits on Sep 16, 2022

  1. Disable MSYS2's path munging for stringreplace

    This was causing our rewriting of the loader's RPATH emulation to fail
    after running `make install`, as MSYS2 was rewriting our list that looks
    like:
    
    ```
    ../bin/libgcc_s_seh-1.dll:../bin/libopenlibm.dll:@../bin/libjulia-internal.dll:@../bin/libjulia-codegen.dll:
    ```
    
    Into one that looked like:
    ```
    ..\bin\libgcc_s_seh-1.dll;..\bin\libopenlibm.dll;@..\bin\libjulia-internal.dll;@..\bin\libjulia-codegen.dll;
    ```
    
    By exporting `MSYS2_ARG_CONV_EXCL='*'` for all `stringreplace`
    invocations, we dodge this issue, as documented by MSYS2 [0].
    
    [0] https://www.msys2.org/wiki/Porting/#filesystem-namespaces
    staticfloat committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    9fe346c View commit details
    Browse the repository at this point in the history