Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider cycleclock() for 32bit ARM targets #47358

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Provider cycleclock() for 32bit ARM targets #47358

merged 1 commit into from
Nov 30, 2022

Conversation

fingolfin
Copy link
Member

@giordano giordano added building Build system, or building Julia or its dependencies system:32-bit Affects only 32-bit systems system:arm ARMv7 and AArch64 labels Oct 27, 2022
ararslan
ararslan reviewed Nov 9, 2022
View reviewed changes
src/julia_internal.h Outdated Show resolved Hide resolved
ararslan
ararslan approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a 32-bit ARM system handy to verify myself but if it resolves the issue for you and doesn't obviously cause any others, this looks good to me. It correctly adjusts the C++ static_cast to a regular C cast and otherwise matches the linked code.

@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Nov 10, 2022
@KristofferC KristofferC mentioned this pull request Nov 17, 2022
Merged
51 tasks
@fingolfin
Copy link
Member Author

Merge please?

@vchuravy vchuravy merged commit 060a492 into JuliaLang:master Nov 30, 2022
KristofferC pushed a commit that referenced this pull request Dec 8, 2022
@fingolfin @KristofferC
Provider cycleclock() for 32bit ARM targets (#47358)
fcf02e8 
Based on https://github.com/google/benchmark/blob/main/src/cycleclock.h

(cherry picked from commit 060a492)
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
Merged
26 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
@fingolfin fingolfin deleted the mh/arm-cycleclock branch January 26, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64 system:32-bit Affects only 32-bit systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning compiling on 32bit ARM systems: No cycleclock() definition for your platform
5 participants
@fingolfin @giordano @ararslan @vchuravy @KristofferC