Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore libgcc_s symlinking in !macOS #47986

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Restore libgcc_s symlinking in !macOS #47986

merged 1 commit into from
Dec 24, 2022

Conversation

antonio-rojas
Copy link
Contributor

Commit c8b72e2 completely removed libgcc_s symlinking (I assume unintentionally) in !macOS.

@antonio-rojas
Restore libgcc_s symlinkin in !macOS
782dd24 
Commit c8b72e2 completely removed libgcc_s symlinking (I assume unintentionally) in !macOS.
@antonio-rojas antonio-rojas mentioned this pull request Dec 24, 2022
Merged
@giordano
Copy link
Contributor

I presume you meant to refer to #45582 because c8b72e2 is the backport of that PR to the 1.8 branch (which should also be fixed at this point), and yes, it wasn't intentional to touch the other platforms. Thanks!

@giordano giordano added building Build system, or building Julia or its dependencies backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Dec 24, 2022
@Keno Keno merged commit ea13810 into JuliaLang:master Dec 24, 2022
@KristofferC
Copy link
Member

What's the effect of this issue?

KristofferC pushed a commit that referenced this pull request Dec 27, 2022
@antonio-rojas
Restore libgcc_s symlinkin in !macOS (#47986)
6adc428 
Commit c8b72e2 completely removed libgcc_s symlinking (I assume unintentionally) in !macOS.

(cherry picked from commit ea13810)
KristofferC pushed a commit that referenced this pull request Dec 27, 2022
@antonio-rojas
Restore libgcc_s symlinkin in !macOS (#47986)
d954d5c 
Commit c8b72e2 completely removed libgcc_s symlinking (I assume unintentionally) in !macOS.

(cherry picked from commit ea13810)
@KristofferC KristofferC mentioned this pull request Dec 27, 2022
Merged
10 tasks
@KristofferC KristofferC mentioned this pull request Jan 10, 2023
Merged
41 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
@KristofferC KristofferC mentioned this pull request Feb 6, 2023
Closed
16 tasks
@KristofferC KristofferC mentioned this pull request Oct 11, 2023
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonio-rojas @giordano @KristofferC @Keno