Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust assertion for pkgimage & code-coverage #48036

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Adjust assertion for pkgimage & code-coverage #48036

merged 1 commit into from
Dec 30, 2022

Conversation

vchuravy
Copy link
Member

Fixes #48035

@vchuravy vchuravy added this to the 1.9 milestone Dec 29, 2022
@vchuravy vchuravy added backport 1.9 Change should be backported to release-1.9 bugfix This change fixes an existing bug pkgimage labels Dec 29, 2022
@vtjnash
Copy link
Sponsor Member

vtjnash commented Dec 30, 2022

SGTM

@vchuravy vchuravy merged commit cc5bc87 into master Dec 30, 2022
@vchuravy vchuravy deleted the vc/fixup_assert branch December 30, 2022 22:38
KristofferC pushed a commit that referenced this pull request Jan 2, 2023
@vchuravy @KristofferC
Adjust assertion for pkgimage & code-coverage (#48036)
106f5be 
(cherry picked from commit cc5bc87)
@KristofferC KristofferC mentioned this pull request Jan 2, 2023
Merged
41 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt Awaiting requested review from maleadt

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug pkgimage
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

Failure to precompile with assertions enabled
3 participants
@vchuravy @vtjnash @KristofferC