Make sure reachable_var not falls into infinite recusion.
#48135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
added
types and dispatch
vtjnash
reviewed
Jan 5, 2023
There was a problem hiding this comment.
LGTM. I think current_env_length is on your other PR though?
/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/julia-master/src/subtype.c:2320:15: error: implicit declaration of function 'current_env_length' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
int len = current_env_length(e);
vtjnash
approved these changes
Jan 5, 2023
41 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jan 16, 2023
(cherry picked from commit de73c26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression caused by 36cd9c6.
This caused a precompile failure in Pkgeval (https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/36cd9c6_vs_79e29e3/AngularMomentumAlgebra.primary.log).
Test added.