[deps/llvm] don't use hardcode LLVM_SHARED_LIB_NAME (#45908)
#48547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hand edited changes to deps/llvm.version and deps/Versions.make Moved LLVM_VER from Versions.make to llvm.version by Tim S. (cherry picked from commit eb72c2a)
stahta01
force-pushed
the
backports-release-1.8
branch
from
5aceb12
to
53225ec
Compare
|
I can not figure out how to change the branch targeted by PR; so, closing this one. |
|
Click on the "Edit" button in the top-right corner, then the target branch names becomes a dropdown menu. You can still reopen this PR and change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit eb72c2a)
I needed this commit when working on trying to get MSys2 MINGW64 to build LLVM; I am working on updating the MSys2 Mingw package for Julia to 1.8.3 or maybe a different version.
I still have to test the commit works; so, might be a day or so before I change from Draft status.
This is the first git cherry-pick commit I have done; so, I want to be extra careful.
Edit: After testing, I found the need to hand edit two files to see if the build issue I am having locally would be fixed by it.
I am still running the tests.
Tim S.