-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force singlethreading during precompilation #48592
force singlethreading during precompilation #48592
Conversation
It seems the
|
Is this a separate bug that we should fix? |
Discussed on slack and it seems logical that it doesn't. |
@nanosoldier |
Your package evaluation job has completed - possible new issues were detected. |
pkgeval seems ok to me |
@@ -2070,7 +2070,8 @@ function create_expr_cache(pkg::PkgId, input::String, output::String, output_o:: | |||
--color=$(have_color === nothing ? "auto" : have_color ? "yes" : "no") | |||
$trace | |||
-`, | |||
"OPENBLAS_NUM_THREADS" => 1), | |||
"OPENBLAS_NUM_THREADS" => 1, | |||
"JULIA_NUM_THREADS" => 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"JULIA_NUM_THREADS" => nothing),
(cherry picked from commit c0d2c57)
(cherry picked from commit c0d2c57)
(cherry picked from commit c0d2c57)
(cherry picked from commit c0d2c57)
(cherry picked from commit c0d2c57)
(cherry picked from commit c0d2c57)
Only allowing 1 julia thread during precompiling packages makes sense in the context that
Pkg.precompile
manages multi-processing, and any multithreading during precompilation risks overloading the systemJULIA_IMAGE_THREADS
env var for controlling that multithreading, whichPkg.precompile
will be taught to manageAnd a niche issue:
incremental = false
mode causesPkg.precompile
to overload all threads when multithreading PackageCompiler.jl#778A pkgeval run would probably be a good idea for this