Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ci->relocatability before caching external specializations #48882

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Check ci->relocatability before caching external specializations #48882

merged 1 commit into from
Mar 3, 2023

Conversation

timholy
Copy link
Sponsor Member

@timholy timholy commented Mar 3, 2023

Fixes #48837

@timholy timholy added the backport 1.9 Change should be backported to release-1.9 label Mar 3, 2023
@vchuravy vchuravy requested a review from vtjnash March 3, 2023 16:21
@gbaraldi
Copy link
Member

gbaraldi commented Mar 3, 2023

Can we test this somehow?

@timholy
Copy link
Sponsor Member Author

timholy commented Mar 3, 2023 •
edited
Loading

I guess we could mutate relocatability for an external CodeInstance. We'd have to pick something owned by Base that we're pretty sure won't ever end up in the sysimg. I guess a sufficiently-generic method on a novel type would make that safe. It's a little artificial, but perhaps worthwhile (I'm on the fence).

@timholy timholy mentioned this pull request Mar 3, 2023
Closed
@vtjnash
Copy link
Sponsor Member

vtjnash commented Mar 3, 2023

Ah, whoops, I mistakenly assumed this was true already of everything in this list

@vtjnash vtjnash merged commit 89f30ff into master Mar 3, 2023
@vtjnash vtjnash deleted the teh/fix_48837 branch March 3, 2023 23:21
@timholy timholy mentioned this pull request Mar 5, 2023
Closed
KristofferC pushed a commit that referenced this pull request Mar 6, 2023
@timholy @KristofferC
staticdata: check ci->relocatability before caching external speciali…
96b3fe3 
…zations (#48882)

Fixes #48837

(cherry picked from commit 89f30ff)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SnoopPrecompile segfault regression with IOCapture.jl
4 participants
@timholy @gbaraldi @vtjnash @KristofferC