Ensure invalidated target gets logged #49048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To interpret causes of invalidation, it's helpful to understand what signature got invalidated. #48954 inadvertently dropped this info from the logging stream; this commit restores it.
This was referenced Mar 18, 2023
vtjnash
reviewed
Mar 20, 2023
| @@ -2021,6 +2021,11 @@ JL_DLLEXPORT void jl_method_table_insert(jl_methtable_t *mt, jl_method_t *method | |||
| } | |||
| jl_array_ptr_1d_push(oldmi, (jl_value_t*)mi); | |||
| invalidate_external(mi, max_world); | |||
| if (_jl_debug_method_invalidation) { | |||
There was a problem hiding this comment.
I don't fully understand this code, but isn't this pushed into the list later if invalidated is set? Why do we need to push something here too? Is this supposed to have a loctag of jl_box_int32(depth=1); instead (and increment depth argument of invalidate_method_instance)?
There was a problem hiding this comment.
The method gets pushed, but not the specific MethodInstance. On previous versions, the format was:
backedge => depth (e.g., `mcc48954i::MethodInstance, 1` in the new test)
targetmi => "jl_method_table_insert" (`target = mc48954i::MethodInstance` in the new test)
targetm => "jl_method_table_insert" (`target = which(mc48954, (AbstractFloat, Int))::Method` in the new test)
Recent master has dropped the middle of this pair; this PR just restores it.
vtjnash
added
backport 1.9
KristofferC
pushed a commit
that referenced
this pull request
Mar 24, 2023
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
To interpret causes of invalidation, it's helpful to understand what signature got invalidated. JuliaLang#48954 inadvertently dropped this info from the logging stream; this commit restores it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To interpret causes of invalidation, it's helpful to understand what signature got invalidated. #48954 inadvertently dropped this info from the logging stream; this commit restores it.