Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use gc preserve instead of noinline to remove allocation in unsafe_write #49125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use gc preserve instead of noinline to remove allocation in unsafe_write #49125

wants to merge 1 commit into from

Conversation

JeffBezanson
Copy link
Member

I'm surprised we didn't change this a long time ago. With this change, we are able to eliminate the allocation of the Ref 🎉

@JeffBezanson JeffBezanson added performance Must go faster io Involving the I/O subsystem: libuv, read, write, etc. labels Mar 23, 2023
@KristofferC
Copy link
Member

KristofferC commented Mar 23, 2023 •
edited
Loading

Did something change since #39759?

@JeffBezanson
Copy link
Member Author

Oh darn, that is really frustrating. I think at least this can be specialized for IOStream since that does not yield.

@KristofferC
Copy link
Member

I should ref #41415 as well.

@nhz2 nhz2 mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
io Involving the I/O subsystem: libuv, read, write, etc. performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffBezanson @KristofferC