allow more statements in generate_precompile.jl #49200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #47259 most Vararg precompile statements actually work, so they should be allowed, and for ones that don't work there's no harm in trying them.
JeffBezanson
added
compiler:precompilation
|
Random example I encountered: |
KristofferC
approved these changes
Mar 30, 2023
KristofferC
pushed a commit
that referenced
this pull request
Apr 9, 2023
(cherry picked from commit 9001ea0)
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
KristofferC
added a commit
to JuliaLang/PackageCompiler.jl
that referenced
this pull request
Apr 23, 2023
this should be fixed, ref JuliaLang/julia#49200
KristofferC
added a commit
to JuliaLang/PackageCompiler.jl
that referenced
this pull request
Apr 23, 2023
this should be fixed, ref JuliaLang/julia#49200
KristofferC
added a commit
to JuliaLang/PackageCompiler.jl
that referenced
this pull request
Apr 23, 2023
this should be fixed, ref JuliaLang/julia#49200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #47259 most Vararg precompile statements actually work, so they should be allowed, and for ones that don't work there's no harm in trying them.
A similar change is needed in PackageCompiler.