Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "delay loading of extensions as much as possible (#48674)" #49257

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

KristofferC
Copy link
Sponsor Member

This reverts commit e3043a8 (#48674).

Fixes #49250

It was decided to disallow cycles in extensions but allow them to be loaded at precompile time.

@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Apr 5, 2023
@oscardssmith oscardssmith added the needs pkgeval Tests for all registered packages should be run with this change label Apr 5, 2023
@KristofferC KristofferC removed the needs pkgeval Tests for all registered packages should be run with this change label Apr 9, 2023
@KristofferC KristofferC mentioned this pull request Apr 9, 2023
26 tasks
@KristofferC KristofferC force-pushed the kc/revert_ext_load branch 3 times, most recently from 67d11df to a854387 Compare April 9, 2023 16:59
@KristofferC KristofferC merged commit ab4863f into master Apr 9, 2023
@KristofferC KristofferC deleted the kc/revert_ext_load branch April 9, 2023 20:04
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 1.9.0-rc2 compared to 1.9.0-rc1 (weak dependencies not loaded correctly at precompilation?)
2 participants