Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate lines in print_stackframe #49751

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Remove duplicate lines in print_stackframe #49751

merged 3 commits into from
Aug 14, 2023

Conversation

BioTurboNick
Copy link
Contributor

@BioTurboNick BioTurboNick commented May 11, 2023 •
edited
Loading

These lines were apparently refactored into print_module_path_file but not removed from print_stackframe.

Also moved the fixup_stdlib_path call because file isn't even used in the parent function.

@BioTurboNick BioTurboNick changed the title Remove duplicate lines in print_stacktrace Remove duplicate lines in print_stackframe May 11, 2023
@timholy
Copy link
Sponsor Member

timholy commented May 12, 2023

Can you add a reference to the PR this corrects? (This also seems to fail tests.)

@BioTurboNick
Copy link
Contributor Author

BioTurboNick commented May 12, 2023 •
edited
Loading

The failure doesn't seem to be related, I'll update the branch to rerun.

This fixes commit b2b8ce8, PR #45069.

@BioTurboNick
Copy link
Contributor Author

Bump - should be a quick merge

@KristofferC KristofferC merged commit 09e8109 into JuliaLang:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BioTurboNick @timholy @KristofferC