improve inferrability of loading.jl #49812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
May 14, 2023
| @@ -1231,7 +1233,7 @@ function insert_extension_triggers(env::String, pkg::PkgId)::Union{Nothing,Missi | |||
| return _insert_extension_triggers(pkg, extensions, weakdeps) | |||
| end | |||
|
|
|||
| d_weakdeps = Dict{String, String}() | |||
| d_weakdeps = Dict{String, Any}() | |||
| for (dep_name, entries) in d | |||
| dep_name in weakdeps || continue | |||
There was a problem hiding this comment.
Does this line need to check if it is in the keys of weakdeps?
There was a problem hiding this comment.
weakdeps here is Vector{String} always since we handle the weakdeps::Dict{String,Any} case above.
aviatesk
added a commit
that referenced
this pull request
May 17, 2023
#49812 introduced a bug and broke the CI. This commit fixes it up.
KristofferC
pushed a commit
that referenced
this pull request
May 17, 2023
51 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 19, 2023
KristofferC
pushed a commit
that referenced
this pull request
May 27, 2023
kpamnany
pushed a commit
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.