Don't depend on CompilerSupportLibraries_jll from OpenBLAS_jll
#49842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important because CSL_jll loads in many other libraries that we may or may not care that much about, such as `libstdc++` and `libgomp`. We load `libstdc++` eagerly on Linux, so that will already be loaded in all cases that we care about, however on macOS we don't generally want that loaded, and this suppresses that. `libgomp` is needed by BB-provided software that uses OpenMP during compilation, however it can conflict with software compiled by the Intel compilers, such as `MKL`. It's best to allow MKL to load its OpenMP libraries first, so delaying loading `libgomp` until someone actually calls `using CompilerSupportLibraries_jll` is the right thing to do. In the future, we want to rework JLLs such that libraries aren't eagerly loaded at JLL `__init__()` time, but rather they should be JIT loaded upon first usage of the library handle itself. This would allow BB to emit much more fine-grained dependency structures, so that the distribution of a set of libraries can happen together, but the loading of said libraries would be independent.
|
It looks like this will also partially fix #49772, since the root cause there is that loading CSL causes libstdc++ to get loaded instead of the correct library for the platform (libc++) and that leads to segfaults for users. |
51 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 19, 2023
Don't depend on `CompilerSupportLibraries_jll` from `OpenBLAS_jll` (cherry picked from commit 98b64b2)
KristofferC
pushed a commit
that referenced
this pull request
May 27, 2023
Don't depend on `CompilerSupportLibraries_jll` from `OpenBLAS_jll` (cherry picked from commit 98b64b2)
kpamnany
pushed a commit
that referenced
this pull request
Jun 21, 2023
Don't depend on `CompilerSupportLibraries_jll` from `OpenBLAS_jll` (cherry picked from commit 98b64b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important because CSL_jll loads in many other libraries that we may or may not care that much about, such as
libstdc++andlibgomp.We load
libstdc++eagerly on Linux, so that will already be loaded in all cases that we care about, however on macOS we don't generally want that loaded, and this suppresses that.libgompis needed by BB-provided software that uses OpenMP during compilation, however it can conflict with software compiled by the Intel compilers, such asMKL. It's best to allow MKL to load its OpenMP libraries first, so delaying loadinglibgompuntil someone actually callsusing CompilerSupportLibraries_jllis the right thing to do.In the future, we want to rework JLLs such that libraries aren't eagerly loaded at JLL
__init__()time, but rather they should be JIT loaded upon first usage of the library handle itself. This would allow BB to emit much more fine-grained dependency structures, so that the distribution of a set of libraries can happen together, but the loading of said libraries would be independent.