Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check call to getrf! #50134

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Add check call to getrf! #50134

merged 2 commits into from
Jun 12, 2023

Commits on Jun 11, 2023

  1. Add check call to getrf! 

    `lu!(A; check=false)` is supposed to disable the checking and leave it to the user:

> When check = true, an error is thrown if the decomposition fails. When check = false, responsibility for checking the decomposition's validity (via issuccess) lies with the user.

However, this is not quite true since `lu!` calls `getrf!` which internally does a check for `chkfinite` which does throw an error. This updates the `getrf!` function to have a `check` argument which is then used by `lu!` to fully disable the error throwing checks.
    @ChrisRackauckas
    ChrisRackauckas authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6024b3b View commit details
    Browse the repository at this point in the history

  2. Update lapack.jl

    @ChrisRackauckas
    ChrisRackauckas authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ea05bb9 View commit details
    Browse the repository at this point in the history