Make sure Core.Compiler can throw kwarg mismatch errors #50174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _new_NamedTuple helper was in a Base-only branch, causing
```
julia> Core.eval(Core.Compiler, quote f(;a=1) = a end)
f (generic function with 1 method)
julia> Core.Compiler.f(;b=2)
ERROR: UndefVarError: `_new_NamedTuple` not defined
Stacktrace:
[1] macro expansion
@ Core.Compiler ./namedtuple.jl:0 [inlined]
[2] structdiff(a::@NamedTuple{b::Int64}, b::Type{NamedTuple{(:a,)}})
@ Core.Compiler ./namedtuple.jl:421
[3] top-level scope
@ REPL[2]:1
```
After this change, we have the expected
```
julia> Core.eval(Core.Compiler, quote f(;a=1) = a end)
f (generic function with 1 method)
julia> Core.Compiler.f(;b=2)
ERROR: MethodError: no method matching f(; b::Int64)
Closest candidates are:
f(; a) got unsupported keyword argument "b"
@ Core REPL[13]:1
Stacktrace:
[1] kwerr(kw::@NamedTuple{b::Int64}, args::Function)
@ Core.Compiler ./error.jl:165
[2] top-level scope
@ REPL[14]:1
```
oscardssmith
approved these changes
Jun 15, 2023
aviatesk
approved these changes
Jun 15, 2023
aviatesk
added a commit
that referenced
this pull request
Sep 19, 2024
Also renames the name of the test function to avoid name collision.
aviatesk
added a commit
that referenced
this pull request
Sep 20, 2024
Also renames the name of the test function to avoid name collision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _new_NamedTuple helper was in a Base-only branch, causing
After this change, we have the expected