Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weird dispatch of * with zero arguments #50411

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Fix weird dispatch of * with zero arguments #50411

merged 3 commits into from
Jul 5, 2023

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Jul 4, 2023 •
edited
Loading

As pointed out on Slack, this error message is not very nice:

julia> *()
ERROR: MethodError: no method matching LinearAlgebra.Rotation(::Vector{Any})

Closest candidates are:
  LinearAlgebra.Rotation(::Array{LinearAlgebra.Givens{T}, 1}) where T
   @ LinearAlgebra ~/.julia/juliaup/julia-1.9.1+0.x64.linux.gnu/share/julia/stdlib/v1.9/LinearAlgebra/src/givens.jl:44

Stacktrace:
 [1] *()
   @ LinearAlgebra ~/.julia/juliaup/julia-1.9.1+0.x64.linux.gnu/share/julia/stdlib/v1.9/LinearAlgebra/src/givens.jl:420
 [2] top-level scope
   @ REPL[1]:1

I hope my PR fixes it, but I don't know what new error might pop up.

@gdalle
Copy link
Contributor Author

gdalle commented Jul 4, 2023 •
edited
Loading

Just built Julia to check: the new error with my fix is the one we want

julia> *()
ERROR: MethodError: no method matching *()

Closest candidates are:
  *(::Bool, ::Complex{Bool})
   @ Base complex.jl:309
  *(::Bool, ::Bool)
   @ Base bool.jl:168
  *(::Bool, ::AbstractIrrational)
   @ Base irrationals.jl:163
  ...

Stacktrace:
 [1] top-level scope
   @ REPL[1]:1

@KristofferC
Copy link
Sponsor Member

Could potentially add a test like @test isempty(methods(*, ()))

@gdalle
Copy link
Contributor Author

gdalle commented Jul 4, 2023

Could potentially add a test like @test isempty(methods(*, ()))

Done, I did it for + too

@KristofferC KristofferC added the backport 1.10 Change should be backported to the 1.10 release label Jul 5, 2023
@KristofferC KristofferC merged commit d70ee20 into JuliaLang:master Jul 5, 2023
2 checks passed
KristofferC pushed a commit that referenced this pull request Jul 11, 2023
@gdalle @KristofferC
Fix weird dispatch of * with zero arguments (#50411)
952f8cb 
(cherry picked from commit d70ee20)
KristofferC pushed a commit that referenced this pull request Jul 11, 2023
@gdalle @KristofferC
Fix weird dispatch of * with zero arguments (#50411)
01f9123 
(cherry picked from commit d70ee20)
@KristofferC KristofferC mentioned this pull request Jul 11, 2023
Merged
45 tasks
KristofferC added a commit that referenced this pull request Jul 24, 2023
@KristofferC
release-1.10: Backports for 1.10-alpha2 (#50508)
f9b2614 
Backported PRs:
- [x] #50411 <!-- Fix weird dispatch of * with zero arguments -->
- [x] #50202 <!-- Remove dynamic dispatch from _wait/wait2 -->
- [x] #50064 <!-- Fix numbered prompt with input only with comment -->
- [x] #50026 <!-- Store heapsnapshot files in tempdir() instead of
current directory -->
- [x] #50402 <!-- Add CPU feature helper function -->
- [x] #50387 <!-- update newpages pointer after actually sweeping pages
-->
- [x] #50424 <!-- avoid potential type-instability in _replace_(str,
...) -->
- [x] #50444 <!-- Optimize getfield lowering to avoid boxing in some
cases -->
- [x] #50474 <!-- docs: Fix a `!!! note` which was miscapitalized -->
- [x] #50466 <!-- relax assertion involving pg->nold to reflect that it
may be a bit in… -->
- [x] #50490 <!-- Fix compat annotation for italic printstyled -->
- [x] #50488 <!-- fix typo in `Base.isassigned` with `Tridiagonal` -->
- [x] #50476 <!-- Profile: Add specifying dir for `take_heap_snapshot`
and handling if current dir is unwritable -->
- [x] #50461 <!-- fix typo in the --gcthreads argument description -->
- [x] #50528 <!-- ssair: Correctly handle stmt insertion at end of basic
block -->
- [x] #50533 <!-- ensure internal_obj_base_ptr checks whether objects
past freelist pointer are in freelist -->
- [x] #49322 <!-- improve cat design / performance -->
- [x] #50540 <!-- gc: remove over-eager assertion -->
- [x] #50542 <!-- gf: remove unnecessary assert cycle==depth -->
- [x] #50559 <!-- Expand kwcall lowering positional default check to
vararg -->
- [x] #50058 <!-- Add unwrapping mechanism for triangular mul and solves
-->
- [x] #50551 <!-- typeintersect: also record chained `innervars` -->
- [x] #50552 <!-- read(io, Char): fix read with too many leading ones
-->
- [x] #50541 <!-- precompile: ensure globals are not accidentally
created where disallowed -->
- [x] #50576 <!-- use atomic compare exchange when setting the GC
mark-bit -->
- [x] #50578 <!-- gf: make method overwrite/delete an error during
precompile -->
- [x] #50516 <!-- Fix visibility of assert on GCC12/13 -->
- [x] #50597 <!-- Fix memory corruption if task is launched inside
finalizer -->
- [x] #50591 <!-- build: fix various makefile bugs -->
- [x] #50599 <!-- faster invalid object lookup in conservative gc -->
- [x] #50634 <!-- 🤖 [master] Bump the SparseArrays stdlib from b4b0e72
to 99c99b4 -->
- [x] #50639 <!-- Backport LLVM patches to fix various issues. -->
- [x] #50546 <!-- Revert storage of method instance in LineInfoNode -->
- [x] #50631 <!-- Shift DCE pass to optimize imaging mode code better
-->
- [x] #50525 <!-- only check that values are finite in `generic_lufact`
when `check=true` -->
- [x] #50587 <!-- isassigned for ranges with BigInt indices -->
- [x] #50144 <!-- Page based heap size heuristics -->


Need manual backport:
- [ ] #50595 <!-- Rename ENV variable `JULIA_USE_NEW_PARSER` ->
`JULIA_USE_FLISP_PARSER` -->



Non-merged PRs with backport label:
- [ ] #50637 <!-- Remove SparseArrays legacy code -->
- [ ] #50618 <!-- inference: continue const-prop' when concrete-eval
returns non-inlineable -->
- [ ] #50598 <!-- only limit types in stack traces in the REPL -->
- [ ] #50594 <!-- Disallow non-index Integer types in isassigned -->
- [ ] #50568 <!-- `Array(::AbstractRange)` should return an `Array` -->
- [ ] #50523 <!-- Avoid generic call in most cases for getproperty -->
- [ ] #50172 <!-- print feature flags used for matching pkgimage -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdalle @KristofferC