Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gf: remove unnecessary assert cycle==depth #50542

Merged
merged 1 commit into from
Jul 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/gf.c
Original file line number Diff line number Diff line change
Expand Up @@ -3426,7 +3426,9 @@ static int sort_mlmatches(jl_array_t *t, size_t idx, arraylist_t *visited, array
}
}
if ((size_t)visited->items[idx] == 1) {
assert(cycle == depth);
// n.b. cycle might be < depth, if we had a cycle with a child
// idx, but since we are on the top of the stack, nobody
// observed that and so we are content to ignore this
size_t childidx = (size_t)arraylist_pop(stack);
assert(childidx == idx); (void)childidx;
assert(!subt || *found_minmax == 2);
Expand Down