Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove :boundscheck argument from Core._svec_ref #50561

Merged
merged 1 commit into from
Jul 17, 2023
Merged

remove :boundscheck argument from Core._svec_ref #50561

merged 1 commit into from
Jul 17, 2023

Commits on Jul 15, 2023

  1. remove :boundscheck argument from Core._svec_ref

    `Core._svec_ref` has accepted `boundscheck`-value as the first argument
    since it was added in #45062. Nonetheless, `Core._svec_ref` simply calls
    `jl_svec_ref` in either the interpreter or the codegen, and thus the
    `boundscheck` value isn't utilized in any optimizations. Rather, even
    worse, this `boundscheck`-argument negatively influences the effect
    analysis (xref #50167 for details) and has caused type inference
    regressions as reported in #50544.
    
    For these reasons, this commit simply eliminates the `boundscheck`
    argument from `Core._svec_ref`. Consequently,
    `getindex(::SimpleVector, ::Int)` is now being concrete-eval eligible.
    
    closes #50544
    aviatesk committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    94ad38e View commit details
    Browse the repository at this point in the history