Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference: continue const-prop' when concrete-eval returns non-inlineable #50618

Merged
merged 1 commit into from
Aug 5, 2023

Commits on Aug 4, 2023

  1. inference: continue const-prop' when concrete-eval returns non-inline…

    …able
    
    This commit fixes the regression in the following example:
    ```julia
    julia> stritr() = iterate(("1", '2'), 1);
    
    julia> @time stritr();
      0.000001 seconds (2 allocations: 64 bytes) # on master
      0.000000 seconds                           # on 1.9
    ```
    
    The problem is that currently we don't inline result of concrete-eval
    when its result is not inlineable, although const-prop' or semi-concrete
    eval may be able to optimize and inline the method body.
    To improve the situation, this commit simply allows
    `abstract_call_method_with_const_args` to continue to const-prop' when
    concrete-eval returned non-inlineable result.
    aviatesk committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ea6f0cc View commit details
    Browse the repository at this point in the history