Fix big(1)^big(-1) #50821
Merged
Fix big(1)^big(-1) #50821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
Aug 7, 2023
JeffBezanson
approved these changes
Aug 7, 2023
Seelengrab
suggested changes
Aug 8, 2023
Co-authored-by: Sukera <11753998+Seelengrab@users.noreply.github.com>
Seelengrab
reviewed
Aug 9, 2023
| @test (big(i)^big(j)) % Int8 === int8_res | ||
| else | ||
| # Test both have exception of the same type | ||
| @test_throws typeof(int8_res) big(i)^big(j) |
There was a problem hiding this comment.
According to my local tests, it is actually possible to check for int8_res directly, which would ensure the error message itself is also the same, helping ensure the error originated from the same location. Is there a reason you prefer only testing the type?
There was a problem hiding this comment.
The error messages for BigInt and Int8 are currently different. This is because Int8 uses throw_domerr_powbysq(x, p) while BigInt has a custom message.
There was a problem hiding this comment.
Ah, good point.. Then this is good to go, I think.
Seelengrab
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives BigInt exponentiation the same edge-case behavior as other integer exponentiation.
The normal integer exponentiation checks if
xis1or-1before erroring if the power is negative.julia/base/intfuncs.jl
Lines 283 to 287 in 9f9e989
With this PR
big(1)^big(-1) == 1,big(-1)^big(-1) == -1andbig(-1)^big(-2) == 1