Add src alignment arg to emit_memcpy #51152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Sep 1, 2023
Comment on lines
552
to
+554
| Value *slot = emit_static_alloca(ctx, to); | ||
| unsigned align = julia_alignment(jlto); | ||
| cast<AllocaInst>(slot)->setAlignment(Align(align)); |
There was a problem hiding this comment.
We should probably make this an argument, since it is pretty much required now by AllocaInst (it will attempt a bad guess if you don't provide it https://llvm.org/doxygen/Instructions_8cpp.html#a35edfaf69cb59d25d92b1e77f0c27530)
vtjnash
reviewed
Sep 1, 2023
gbaraldi
commented
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
src/cgutils.cpp
Outdated
| @@ -3110,7 +3110,7 @@ static void init_bits_cgval(jl_codectx_t &ctx, Value *newv, const jl_cgval_t& v, | |||
| { | |||
| // newv should already be tagged | |||
| if (v.ispointer()) { | |||
| emit_memcpy(ctx, newv, jl_aliasinfo_t::fromTBAA(ctx, tbaa), v, jl_datatype_size(v.typ), sizeof(void*)); | |||
| emit_memcpy(ctx, newv, jl_aliasinfo_t::fromTBAA(ctx, tbaa), v, jl_datatype_size(v.typ), sizeof(void*), sizeof(void*)); | |||
There was a problem hiding this comment.
newv was a jl_value_t*, so it had heap-alignment, but v is not, so it has julia_alignment
vtjnash
reviewed
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
vtjnash
reviewed
Sep 1, 2023
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
|
bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maybe allows for LLVM to optimize things a bit further since some passes check if both sides have correct/equal alignment