Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete false & true more generally as vals #51326

Merged
merged 2 commits into from
Sep 15, 2023
Merged

complete false & true more generally as vals #51326

merged 2 commits into from
Sep 15, 2023

Conversation

IanButterworth
Copy link
Sponsor Member

Fixes #49892

I'm not sure whether separating the concepts of "keyvals" for false & true from the list of "keywords" is strictly correct, but they seem to be different conceptually.

@IanButterworth IanButterworth added the REPL Julia's REPL (Read Eval Print Loop) label Sep 15, 2023
IanButterworth
IanButterworth commented Sep 15, 2023
View reviewed changes
stdlib/REPL/src/REPLCompletions.jl
@@ -926,6 +937,7 @@ function complete_keyword_argument(partial, last_idx, context_module)

suggestions = Completion[KeywordArgumentCompletion(kwarg) for kwarg in kwargs]
append!(suggestions, complete_symbol(nothing, last_word, Returns(true), context_module))
append!(suggestions, complete_keyval(last_word))
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual fix

@IanButterworth IanButterworth added backport 1.9 Change should be backported to release-1.9 backport 1.10 Change should be backported to the 1.10 release labels Sep 15, 2023
giordano
giordano approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with REPL internals, but I can confirm this PR fixes the reported problem, thanks! I'm also not sure why false and true were in sorted_keywords together with the other keyword, it doesn't feel like they fit together with them

@IanButterworth
Copy link
Sponsor Member Author

Agreed. I do think this change is logical, and if this does break anything, there weren't tests for it, and it can be tweaked.

@IanButterworth IanButterworth merged commit e85f0a5 into JuliaLang:master Sep 15, 2023
8 checks passed
@IanButterworth IanButterworth deleted the ib/fix_bool_completion branch September 15, 2023 18:02
NHDaly pushed a commit that referenced this pull request Sep 20, 2023
@IanButterworth @NHDaly
complete false & true more generally as vals (#51326)
91965a8
@KristofferC KristofferC mentioned this pull request Oct 3, 2023
Merged
31 tasks
IanButterworth added a commit that referenced this pull request Oct 4, 2023
@IanButterworth
complete false & true more generally as vals (#51326)
8cb3197 
(cherry picked from commit e85f0a5)
@KristofferC KristofferC mentioned this pull request Oct 11, 2023
Merged
31 tasks
KristofferC added a commit that referenced this pull request Nov 2, 2023
@KristofferC
Backports release 1.10 (#51563)
1391444 
Backported PRs:
- [x] #50932 <!-- types: fix hash values of Vararg -->
- [x] #50975 <!-- Use rr-safe `nopl; rdtsc` sequence -->
- [x] #50989 <!-- fix incorrect results in `expm1(::Union{Float16,
Float32})` -->
- [x] #51284 <!-- Avoid infinite loop when doing SIGTRAP in arm64-apple
-->
- [x] #51332 <!-- Add s4 field to Xoshiro -->
- [x] #51397 <!-- call Pkg precompile hook in latest world -->
- [x] #51405 <!-- Remove fallback that assigns a module to inlined
frames. -->
- [x] #51491 <!-- Throw clearer ArgumentError for strip with two string
args -->
- [x] #51531 <!-- fix `_tryonce_download_from_cache` (busybox.exe
download error) -->
- [x] #51541 <!-- Fix string index error in tab completion code -->
- [x] #51530 <!-- Don't mark nonlocal symbols as hidden -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51512 <!-- avoid limiting Type{Any} to Type -->
- [x] #51595 <!-- reset `maxprobe` on `empty!` -->
- [x] #51582 <!-- Aggressive constprop in LinearAlgebra.wrap -->
- [x] #51592 <!-- correctly track element pointer in heap snapshot -->
- [x] #51326 <!-- complete false & true more generally as vals -->
- [x] #51376 <!-- make `hash(::Xoshiro)` compatible with `==` -->
- [x] #51557 <!-- Fix last startup & shutdown precompiles -->
- [x] #51845 
- [x] #51840 
- [x] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [x] #51863 <!-- LLVM 15.0.7-9 -->

Contains multiple commits, manual intervention needed:

- [ ] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are
now first class -->
- [ ] #51092 <!-- inference: fix bad effects for recursion -->

Non-merged PRs with backport label:
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
- [ ] #51414 <!-- improvements on GC scheduler shutdown -->
- [ ] #51366 <!-- Handle infix operators in REPL completion -->
- [ ] #50919 <!-- Code loading: do the "skipping mtime check for stdlib"
check regardless of the value of `ispath(f)` -->
- [ ] #50824 <!-- Add some aliasing warnings to docstrings for mutating
functions in Base -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Nov 2, 2023
nalimilan pushed a commit that referenced this pull request Nov 5, 2023
@IanButterworth @nalimilan
complete false & true more generally as vals (#51326)
31ea32b 
(cherry picked from commit e85f0a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
backport 1.9 Change should be backported to release-1.9 REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REPL: true and false aren't autocompleted in function arguments
3 participants
@IanButterworth @giordano @KristofferC