Disambiguate mul! for matvec and matmat through indirection #52837
+88
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forwards
mul!
for matrix-matrix and matrix-vector multiplications to the internal_mul!
, which is then specialized for the various array types. With this, packages would not encounter any method ambiguity when they defineThis should reduce the number of methods that packages need to define to work around ambiguities with
LinearAlgebra
.There was already an existing internal function named
_mul!
, but the new methods don't clash with the existing ones, and since both sets of methods usually forward structured multiplications to specialized functions, it's fitting for them to have the same name.