Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posix compatibility: avoid grep GNU extension #53400

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Feb 20, 2024

the .\+ meta-character is a GNU extension. prefer to use the POSIX equivalent .\{1,\} to work with grep on wider platforms.

it is part of on-going work to port julia to OpenBSD.

the `.\+` meta-character is a GNU extension. prefer to use the POSIX equivalent `.\{1,\}` to work with `grep` on wider platforms.
@inkydragon inkydragon added the building Build system, or building Julia or its dependencies label Feb 20, 2024
src/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Feb 20, 2024
@fingolfin fingolfin merged commit 4e72944 into JuliaLang:master Feb 21, 2024
6 of 8 checks passed
@semarie semarie deleted the posix-grep branch February 21, 2024 09:13
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Feb 23, 2024
tecosaur pushed a commit to tecosaur/julia that referenced this pull request Mar 4, 2024
the `.\+` meta-character is a GNU extension. prefer to use the POSIX
equivalent `..*` to work with `grep` on wider platforms.

it is part of on-going work to port julia to OpenBSD.
mkitti pushed a commit to mkitti/julia that referenced this pull request Mar 7, 2024
the `.\+` meta-character is a GNU extension. prefer to use the POSIX
equivalent `..*` to work with `grep` on wider platforms.

it is part of on-going work to port julia to OpenBSD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants