Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the readline REPL is going to be substituted with pure julia, but since that does not seem to be as imminent as I used to think and since not having file completion is really annoying, I patched the repl-readline code to do file completion on tab under two circumstances: 1) within strings 2) when the line starts with
;
.The fist case is a bit complicated to do properly and the resulting code is not really nice looking, but it mostly works (most common cases such as escaping and similar are covered; I hope I haven't missed anything obvious; the only situation I can think of where it would fail to work properly is a string within an interpolation within a string, but surely there are other failure scenarios if one tries hard enough). Anyway, this is code which is supposed to be short-lived, and I think it's still better than what we have now.