Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inlining: remove unused allow_abstract::Bool keyword argument #53601

Merged
merged 1 commit into from
Apr 10, 2024
Merged

inlining: remove unused allow_abstract::Bool keyword argument #53601

merged 1 commit into from
Apr 10, 2024

Conversation

aviatesk
Copy link
Sponsor Member

@aviatesk aviatesk commented Mar 5, 2024

No description provided.

vtjnash
vtjnash approved these changes Mar 5, 2024
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I assumed this was present for external interpreters, so if they don't need it, we can delete it

@vtjnash vtjnash added the compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) label Mar 5, 2024
Base automatically changed from avi/53590 to master March 7, 2024 16:15
@aviatesk
Copy link
Sponsor Member Author

aviatesk commented Mar 7, 2024

The previous inlining algorithm used it, but it seems like we don't use it anymore.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Mar 7, 2024

AFAICT, not using that anymore is actually a bug in the current algorithm: #53600 (comment)

@aviatesk aviatesk force-pushed the avi/rm-allow_abstract branch 2 times, most recently from 9b0ea8d to 33da26a Compare March 21, 2024 23:55
@aviatesk aviatesk merged commit 45fb084 into master Apr 10, 2024
7 checks passed
@aviatesk aviatesk deleted the avi/rm-allow_abstract branch April 10, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
compiler:optimizer Optimization passes (mostly in base/compiler/ssair/)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @vtjnash