documentation followup for "invert linetable representation (#52415)" #53781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
commented
Mar 19, 2024
test/show.jl
Outdated
| test_DILineInfoPrinter(42) # ensure we have code instance cache for `test_DILineInfoPrinter(::Int)` | ||
| let io = IOContext(IOBuffer(), :color=>true) | ||
| mi = only(methods(test_DILineInfoPrinter, (Int,))).specializations | ||
| src = Core.Compiler._uncompressed_ir(mi.cache, mi.cache.inferred::String) |
There was a problem hiding this comment.
This bit seems pretty hacky, but we currently can't use code_typed here. Since @code_typed func(args...) doesn't trigger caching for func(args...) because typeinf_code doesn't call lock_mi_inference beforehand. Should typeinf_code be tweaked to set lock_mi_inference?
aviatesk
force-pushed
the
avi/follow-52415
branch
2 times, most recently
from
1dd4c9c
to
58e46fd
Compare
|
Not sure if this is the right place to indicate but IIUC the two following items should be replaced with Lines 699 to 706 in 58e46fd I propose something along the line of: I can open a separate pr if needed. |
aviatesk
force-pushed
the
avi/follow-52415
branch
from
58e46fd
to
b4907eb
Compare
aviatesk
changed the title
|
@Pangoraw Thanks for your suggestion! |
aviatesk
force-pushed
the
avi/follow-52415
branch
from
b4907eb
to
7e6e86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set up a specific type to capture the 3-set data of(moved to a separate PR)codelocs: 6afde4b