Rename the internal union OneBasedRanges to _OneBasedRanges

[jishnub]

This makes auto-completing Base.OneTo easier, as there's no ambiguity with this internal union. The leading underscore may also signal that the name is internal to Base.

[IanButterworth]

Or we make autocomplete hints for private names a bit slower and require tab + another key combination.

[jishnub]

That's certainly a better longer-term solution

[LilithHafner]

We could also replace this internal union with a trait over types

is_one_based(::Type{AbstractArray}) = false
is_one_based(::Type{Array}) = true
is_one_based(::Type{OneTo}) = true
is_one_based(::Type{IdentityUnitRange{T}}) where T = is_one_based(T)
is_one_based(::AbstractArray) = throw(helpful error message)

and then also use it here

julia/base/genericmemory.jl

Lines 301 to 307 in f30aae5

	"""
	view(m::GenericMemory{M, T}, inds::Union{UnitRange, OneTo})
	Create a vector `v::Vector{T}` backed by the specified indices of `m`. It is only safe to
	resize `v` if `m` is subseqently not used.
	"""
	function view(m::GenericMemory{M, T}, inds::Union{UnitRange, OneTo}) where {M, T}

[fingolfin]

I like the trait idea by @LilithHafner but perhaps that's for a future PR?