Mark ScopedValue, with and @with as public

[jakobnissen]

This is exported from the ScopedValues module into Base, but not exported from Base, and therefore not marked as public.

[nsajko]

BTW, I don't think you want to tag the Github user @with in the commit message.

[nsajko]

Updates #51335

Follows up on #54574

[jakobnissen]

It can't be marked as public inside ScopedValues because it is exported (this errors). It also makes no sense to export it from ScopedValues to Base, have it be public in ScopedValues but private in Base. If it was supposed to be private in Base, why is it exported to Base?

[CameronBieganek]

If it was supposed to be private in Base, why is it exported to Base?

@with is used in a couple places in Base, and also one place in the unit tests. (I mean in addition to the unit tests for the ScopedValues module.)

with and @with are extremely generic names, which I think is why some folks would like to keep those names contained in Base.ScopedValues. My preferred access pattern is either of the following:

using Base.ScopedValues

# or:

using Base.ScopedValues: ScopedValue, with

I would like to add the ScopedValues module to the Base export list (as is done for Iterators, Threads, and Sys), but it was pointed out that that could cause confusion if folks are also trying to use the ScopedValues.jl package for backwards compatibility. (See #54556.)

[LilithHafner]

I don't think these names should be loaded into Base. I'd rather see Base.ScopedValues. IMO Base should load ScopedValues with import, which would make @CameronBieganek's access patterns the only viable patters (loading from Base would no longer be an option).

[nsajko]

I guess this can be closed now, Base.ScopedValues.ScopedValue is public.