replace some occurrences of iteration over 1:length with more idiomatic structures (mostly eachindex) #55137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c structures (mostly eachindex)
|
Should probably be backported? |
tecosaur
approved these changes
Jul 16, 2024
tecosaur
added
iteration
jishnub
added
backport 1.10
KristofferC
reviewed
Jul 16, 2024
| @@ -978,7 +978,7 @@ end | |||
|
|
|||
| Return an array with element type `T` (default `Int`) of the digits of `n` in the given | |||
| base, optionally padded with zeros to a specified size. More significant digits are at | |||
| higher indices, such that `n == sum(digits[k]*base^(k-1) for k=1:length(digits))`. | |||
| higher indices, such that `n == sum(digits[k]*base^(k-1) for k in eachindex(digits))`. | |||
There was a problem hiding this comment.
I think this was clearer before since one is taking an exponential of k. The genericness of iterating indices just takes away from the point being made.
There was a problem hiding this comment.
That's a reasonable position. OTOH, with 1:length, you have to worry about bounds errors which also distracts from the point. Personally, I think it's similar either way.
42 tasks
KristofferC
removed
backport 1.10
IanButterworth
added
the
backport 1.11
|
Not clear why this was removed from backport. Adding it back to 1.11 at least as it makes other things easier to backport. |
IanButterworth
pushed a commit
to IanButterworth/julia
that referenced
this pull request
Nov 6, 2024
…ic structures (mostly eachindex) (JuliaLang#55137) Base should be a model for the ecosystem, and `eachindex(x)` is better than `1:length(x)` in almost all cases. I've updated many, but certainly not all examples. This is mostly a NFC, but also fixes JuliaLang#55136. (cherry picked from commit 0945b9d)
KristofferC
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base should be a model for the ecosystem, and
eachindex(x)is better than1:length(x)in almost all cases. I've updated many, but certainly not all examples. This is mostly a NFC, but also fixes #55136.