LinearAlgebra: use ≈
instead of ==
for tr
tests in symmetric.jl
#55143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating JuliaLang/LinearAlgebra.jl#1064, I found that the issue was not caused by the effects of
checksquare
, but by the use of the@simd
macro withintr(::Matrix)
:julia/stdlib/LinearAlgebra/src/dense.jl
Lines 373 to 380 in 0945b9d
While simply removing the
@simd
macro was considered, the strict left-to-right summation without@simd
otherwise is not necessarily more accurate, so I concluded that the problem lies in the test code, which tests the (strict) equality of two differenttr
execution results. I have modified the test code to use≈
instead of==
.@show
in error path LinearAlgebra.jl#1064