Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtype: fast path for Type == TypeVar #56640

Merged
merged 1 commit into from
Nov 26, 2024
Merged

subtype: fast path for Type == TypeVar #56640

merged 1 commit into from
Nov 26, 2024

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Nov 21, 2024

close #56606

@N5N3 N5N3 added types and dispatch Types, subtyping and method dispatch needs pkgeval Tests for all registered packages should be run with this change backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Nov 21, 2024
@N5N3 N5N3 requested a review from vtjnash November 21, 2024 17:27
N5N3
N5N3 commented Nov 21, 2024
View reviewed changes
src/subtype.c Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topolarity topolarity mentioned this pull request Nov 21, 2024
Open
@oscardssmith oscardssmith added the performance Must go faster label Nov 21, 2024
This was referenced Nov 22, 2024
Merged
Open
@N5N3 N5N3 force-pushed the fst_eq_var branch 2 times, most recently from 3922d33 to 9087b94 Compare November 22, 2024 13:17
@N5N3
Copy link
Member Author

N5N3 commented Nov 22, 2024

@nanosoldier runtests()

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@N5N3 N5N3 marked this pull request as draft November 24, 2024 03:24
@N5N3 N5N3 marked this pull request as ready for review November 24, 2024 14:54
@N5N3
Copy link
Member Author

N5N3 commented Nov 24, 2024

@nanosoldier runtests(["MethodInspector", "Algoim", "TuePlots", "AxisKeysExtra", "GLPK", "LazySets", "Optim", "SliceSampling", "LSODA", "OrdinaryDiffEqAdamsBashforthMoulton", "OrdinaryDiffEqNordsieck", "OrdinaryDiffEqLowOrderRK", "OrdinaryDiffEqStabilizedRK", "OrdinaryDiffEqQPRK", "OrdinaryDiffEqSSPRK", "OrdinaryDiffEqFeagin", "EconomicScenarioGenerators", "ParticleInCell", "GeometryOptimization", "FinanceModels", "FSimZoo", "BoundaryValueDiffEqMIRKN", "ODEProblemLibrary", "Yunir", "SymbolicInference", "FrequencySweep", "BatchReactor", "PlugFlowReactor", "SymbolicNumericIntegration"])

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@N5N3 N5N3 removed the needs pkgeval Tests for all registered packages should be run with this change label Nov 26, 2024
@N5N3 N5N3 merged commit 7df1dfa into JuliaLang:master Nov 26, 2024
5 of 9 checks passed
@N5N3 N5N3 deleted the fst_eq_var branch November 26, 2024 00:16
KristofferC pushed a commit that referenced this pull request Dec 3, 2024
@N5N3
subtype: fast path for Type == TypeVar (#56640)
c3449dc 
close #56606

(cherry picked from commit 7df1dfa)
@KristofferC KristofferC mentioned this pull request Dec 3, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 performance Must go faster types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extremely slow subtype query causes unreasonable compilation times
4 participants
@N5N3 @nanosoldier @vtjnash @oscardssmith