Add option to use @spawn :samepool for using the same threadpool as the caller
#57109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/spawn_same
branch
from
872e3f2 to
72c6632
Compare
IanButterworth
commented
Jan 20, 2025
|
Maybe |
IanButterworth
force-pushed
the
ib/spawn_same
branch
from
ef14553 to
ff909c1
Compare
IanButterworth
changed the title
@spawn :same for using the same threadpool as the caller@spawn :samepool for using the same threadpool as the caller
|
No objections raised here or #multithreading on slack so I'll go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Threads.@spawn :samepool foo()as shorthand forThreads.@spawn Threads.threadpool() foo()to make it easier to stick within the same threadpool.ConcurrentUtilities.jl already demonstrates this is desired functionality.
One common use for this is replacing
@asyncwith@spawnwhen there's an interactive thread, given that the main task runs on thread 1, so a bare@spawnwill change threadpool to:default, perhaps unexpectedly.