Use INFINITY and NAN instead of strtod #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added a commit
that referenced
this pull request
Apr 4, 2014
Use INFINITY and NAN instead of strtod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error
syntax: overflow in numeric constant "0"in MSVC builds (thanks @vtjnash for figuring this out).strtodis not C99 compliant in any currently-released version of Visual Studio, though it will apparently be fixed for the next release. TheINFINITYandNANidentifiers were added tomath.honly in VS 2013. Could maybe fall back toopenlibm.hinstead? Ref. #6230 and #6349.Also adds
extern "C"on bitvector - there will be several more of these, for ccall-only functions that weren't needed to link libjulia or the REPL exe.