Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7203 and #7218 #7220

Merged
merged 1 commit into from
Jun 13, 2014
Merged

fix #7203 and #7218 #7220

merged 1 commit into from
Jun 13, 2014

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jun 11, 2014

for Windows users who have git configured with \r\n line endings,
or modify the source in an editor that always uses \r\n

for Windows users who have git configured with \r\n line endings,
or modify the source in an editor that always uses \r\n
This was referenced Jun 11, 2014
@vtjnash
Copy link
Member

vtjnash commented Jun 13, 2014

There is something slightly evil about not getting back the bytes that you tried to just write. I'm inclined to just add an assertion to the makefile that you have configured git to preserve line endings.

@Keno
Copy link
Member

Keno commented Jun 13, 2014

I'm in agreement with Jameson.

@JeffBezanson
Copy link
Member

I agree with Keno and Jameson, but the rest of this test file does use $(nl) everywhere, so we might as well be consistent.

JeffBezanson added a commit that referenced this pull request Jun 13, 2014
@JeffBezanson JeffBezanson merged commit c3f252f into JuliaLang:master Jun 13, 2014
@tkelman tkelman deleted the patch-4 branch June 14, 2014 03:09
@tkelman
Copy link
Contributor Author

tkelman commented Jun 14, 2014

I agree that we should encourage configuring git to always use unix line endings, but what about someone who installs from a binary, then modifies the test in some trivial way in a lousy editor? I think we should encourage everyone who installs a binary to immediately run the test suite as the first thing they do, but there are still several failures remaining until tests can all pass on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants