allow x[i,j;k] syntax to be parsed

[jakebolewski]

See #7225 && JuliaLang/JuliaParser.jl#8

[jakebolewski]

It's nice that after #8190 this also prints correctly.

[JeffBezanson]

Thanks for taking care of this. This is pretty much right, but I found this:

> (julia-parse "[b,c;d,e]")
(vcat (parameters d e) b c)

julia> [1,2;3,4]
ERROR: syntax: invalid keyword argument syntax "3" (expected assignment)

julia> [1, 2; a=3]
ERROR: syntax: invalid keyword argument syntax "a=3" (expected assignment)

[jakebolewski]

I thought that this syntax was supposed to be parseable but still not valid Julia syntax (so that the JUMP guys could use it in their macros, but it remains an invalid Julia expression)?

Obviously it would be better to agree on what this would mean and make it valid syntax as well. I don't see how [1,2; a=3] could ever be a valid expression.

[JeffBezanson]

Parsing a[i,j;k] is ok, but [1,2;3,4] is sketchier since it looks like matrix syntax. Also the error message in the last case is pretty confusing.

[jakebolewski]

I agree it is sketchy, what would you like to do? Throw a better error message? (Something like, Error: syntax: [1,2;3,4] is not valid matrix syntax)?

[JeffBezanson]

Yeah that would be better, until we figure something else out.

[jakebolewski]

We currently give this error for cell arrays:

julia> {1,2;3,4}
ERROR: unsupported or misplaced expression parameters

would it be sufficient to make the error messages the same (for 0.3)? We could always come back and clean up this up later for 0.4. As JUMP will probably be using 0.3 for a while, it would be nice to backport this change for them.

[joehuchette]

Backporting this to 0.3 would be fantastic for us, if that's a reasonable request. Thanks for this, @jakebolewski!

[IainNZ]

💯

[jakebolewski]

Updated now that the 0.3.1 window is closing. This should preserve the old syntax error behavior now.

julia> [1,2;3,4]
ERROR: syntax: unexpected semicolon in array expression

julia> {1,2;3,4}
ERROR: syntax: unexpected semicolon in array expression

julia> Int[1,2;3,4]
ERROR: syntax: unexpected semicolon in array expression

julia> [1,2;a=3]
ERROR: syntax: unexpected semicolon in array expression

julia> {1,2;a=3}
ERROR: syntax: unexpected semicolon in array expression

julia> Int[1,2;a=3]
ERROR: syntax: unexpected semicolon in array expression

[IainNZ]

👍

[JeffBezanson]

This doesn't work, because it gives

julia> vcat(x;a=1)
ERROR: syntax: unexpected semicolon in array expression

[jakebolewski]

I don't know why I didn't add the check when expanding 'vcat, will fix.

[jakebolewski]

@JeffBezanson can you have another look at this so it can be backported?

[mlubin]

👍

[jakebolewski]

@JuliaBackports

[joehuchette]

Awesome, thanks @jakebolewski!

[andreasnoack]

Is this one causing the ErrorException("new: too many arguments")s I get when I try to build latest master? E.g. at LoadError(at "bitarray.jl" line 379, and LoadError(at "osutils.jl" line 38

[jakebolewski]

Was it this or 7f2cf32?

[andreasnoack]

I did a git pull and got many weird errors. However, a git reset --hard origin/master seems to have solved the problem.

[ivarne]

Was there any problem with this, or is it time to backport to release-0.3?

I've used my quota for mistakes this week, so someone else will have to do the honours 😜

[staticfloat]

895639a :)