Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text says AST, example shows backtrace. #8258

Closed
wants to merge 1 commit into from

Conversation

wbhart
Copy link

@wbhart wbhart commented Sep 6, 2014

No description provided.

@StefanKarpinski
Copy link
Member

It prints the expression followed by a backtrace. AST isn't really the right word, but the backtrace bit isn't really the most significant part either.

@ivarne
Copy link
Member

ivarne commented Sep 8, 2014

Maybe print the expression that failed, along with the values and backtrace?

The more glaring issue is that these code blocks should be doctest, so that the change in output of the @test macro has not been caught (yet).

@wbhart
Copy link
Author

wbhart commented Sep 8, 2014

The thing that I missed, even with the strange wording, was that it prints
the expression itself. That's important enough to emphasise separately I
think.

Just a suggestion, but maybe:

Prints a backtrace for the failure. Note that the original expression which
failed is quoted before the backtrace.

On 8 September 2014 21:17, Ivar Nesje notifications@github.com wrote:

Maybe print the expression that failed, along with the values and
backtrace?

The more glaring issue is that these code blocks should be doctest, so
that the change in output of the @test macro has not been caught (yet).


Reply to this email directly or view it on GitHub
#8258 (comment).

@ihnorton
Copy link
Member

ihnorton commented Oct 8, 2015

This text has been significantly reworked (#13062).

@ihnorton ihnorton closed this Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants