Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md to add line length limit #9848

Merged
merged 1 commit into from
Jan 22, 2015

Conversation

jakebolewski
Copy link
Member

Prompted by encountering some 250+ character lines in the linear algebra library

Also add naming conventions for modules, types, and methods.

[ci skip]

Prompted by encountering some 250+ character lines in the linear algebra library

Also add naming conventions for modules, types, and methods.

[ci skip]
- comments are good, especially when they explain the algorithm
- try to adhere to a 92 character line length limit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did 92 come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An arbitrary number less than 250.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like Fortran!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to beat the classics:

latest

ref

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with optional command line flag, you get to upgrade to 132 characters per line :-)

@iamed2
Copy link
Contributor

iamed2 commented Jan 20, 2015

Python's PEP8 suggests 99 as a hard max, why not that? Seems like as good a reason as any.

@elextr
Copy link

elextr commented Jan 20, 2015

rand()*250 gives 100.00978344188333 (in Julia 0.3.5) so 99 looks like it 😉

@iamed2
Copy link
Contributor

iamed2 commented Jan 21, 2015

Oh weird, it gives me 134.59251205400307 on 0.4. Is this a regression? ;)

@elextr
Copy link

elextr commented Jan 21, 2015

On 21 January 2015 at 15:12, iamed2 notifications@github.com wrote:

Oh weird, it gives me 134.59251205400307 on 0.4. Is this a regression? ;)

​No, it is random :)

Cheers
Lex

PS today I got ​169.56878644092737, I presume it depends on your systems
entropy, it was just lucky that time :)


Reply to this email directly or view it on GitHub
#9848 (comment).

@eschnett
Copy link
Contributor

julia> rand()*250
80.38026797235948

And I only needed two tries to get that result!

-erik

On Jan 21, 2015, at 2:14 , elextr notifications@github.com wrote:

On 21 January 2015 at 15:12, iamed2 notifications@github.com wrote:

Oh weird, it gives me 134.59251205400307 on 0.4. Is this a regression? ;)

​No, it is random :)

Cheers
Lex

PS today I got ​169.56878644092737, I presume it depends on your systems
entropy, it was just lucky that time :)


Reply to this email directly or view it on GitHub
#9848 (comment).


Reply to this email directly or view it on GitHub.

Erik Schnetter schnetter@gmail.com
http://www.perimeterinstitute.ca/personal/eschnetter/

My email is as private as my paper mail. I therefore support encrypting
and signing email messages. Get my PGP key from https://sks-keyservers.net.

jiahao added a commit that referenced this pull request Jan 22, 2015
Update CONTRIBUTING.md to add line length limit
@jiahao jiahao merged commit cd0ff78 into master Jan 22, 2015
@jiahao jiahao deleted the jakebolewski-patch-1-1 branch January 22, 2015 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants