-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md to add line length limit #9848
Conversation
Prompted by encountering some 250+ character lines in the linear algebra library Also add naming conventions for modules, types, and methods. [ci skip]
- comments are good, especially when they explain the algorithm | ||
- try to adhere to a 92 character line length limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did 92 come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An arbitrary number less than 250.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like Fortran!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with optional command line flag, you get to upgrade to 132 characters per line :-)
Python's PEP8 suggests 99 as a hard max, why not that? Seems like as good a reason as any. |
|
Oh weird, it gives me 134.59251205400307 on 0.4. Is this a regression? ;) |
On 21 January 2015 at 15:12, iamed2 notifications@github.com wrote:
No, it is random :) Cheers PS today I got 169.56878644092737, I presume it depends on your systems
|
julia> rand()*250 And I only needed two tries to get that result! -erik
Erik Schnetter schnetter@gmail.com My email is as private as my paper mail. I therefore support encrypting |
Update CONTRIBUTING.md to add line length limit
Prompted by encountering some 250+ character lines in the linear algebra library
Also add naming conventions for modules, types, and methods.
[ci skip]