-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD support #872
base: main
Are you sure you want to change the base?
FreeBSD support #872
Conversation
Backtrace from tests (click to expand)
|
Actually the unpacking thing might be a red herring possibly caused by Line 48 in 20a20b9
libjulia-codegen.so.1.12 can't load libLLVM-16jl.so . Last I checked (a day or two ago) I didn't see that locally when manually downloading, unpacking, and using nightly. So still doesn't work but... progress?
|
Swapping the |
...except it didn't fail on CI, huh. The test I mentioned fails locally. |
Some to-do items:
|
|
Unlike most systems, we can be quite sure that `tar` exists when running on FreeBSD, so it should be safe to call out to it and fail with a descriptive error in the off chance that the host system is weird. This allows us to avoid using the Rust tar library, which does not currently support the POSIX-2008.1 format that is produced by default by BSD tar.
7677e0b
to
76dfa62
Compare
Everything is working now, though I ended up taking a slightly different approach from when I started this. It looks like it might be a long time before the tar-rs PR that would allow us to properly read tarballs produced by BSD tar is merged, if it ever is. In the meantime, we can simply spawn a I think this is finally ready for review, @davidanthoff. It's worth noting up front that I don't actually know Rust so there may be better ways to implement this approach. |
This doesn't yet pass tests because the tarball fails to extract and I don't understand why. The URL it's using is correct and I'm able to download and unpack manually.