-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix is_juliaup_installed
for invalid path
#880
Conversation
is_juliaup_installed
is_juliaup_installed
for invalid path
@davidanthoff, bump ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a Rust programmer but this looks reasonable to me. If no feedback in a week, I will merge.
Hm, I'm not sure this is a good idea. If the user has a script Could you move the unrelated typo fix to a different PR? Thanks! |
Exactly. Currently, |
Done in #916. |
This PR:
juliainstaller
up fails whenjuliaup
fails to execute #879;changes the.--add_to_path
description (juliainstaller --help
) to match the command line argument--add-to-path
(underscore -> dash)