Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures from #28, turn on Travis here #1

Closed
tkelman opened this issue Nov 21, 2014 · 1 comment
Closed

Fix test failures from #28, turn on Travis here #1

tkelman opened this issue Nov 21, 2014 · 1 comment

Comments

@tkelman
Copy link

tkelman commented Nov 21, 2014

Some asserts from 5599b8c are messed up, but I'm not sure on the right way to fix them. There's also

lt-run-tests: src/unix/loop.c:93: uv_loop_delete: Assertion `uv_loop_close(loop) == 0' failed.

from a different test, ref #28.
vtjnash referenced this issue in JuliaAttic/libuv-archive Jul 18, 2015
@saghul
doc: clarify how uv_async_send behaves
c9c00cd 
Closes #29

PR-URL: libuv/libuv#122
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@vtjnash vtjnash closed this as completed May 5, 2018
@tkelman
Copy link
Author

tkelman commented May 5, 2018

Is travis running here? No? Not closed.

@tkelman tkelman reopened this May 5, 2018
@vtjnash vtjnash transferred this issue from JuliaAttic/libuv-archive Apr 2, 2019
musm pushed a commit to musm/libuv that referenced this issue Apr 8, 2019
@kivikakk @cjihrig
unix: zero epoll_event before use
0813f5b 
Valgrind will emit the following error on a system where `int` is 32
bits:

==21616== Syscall param epoll_ctl(event) points to uninitialised byte(s)
==21616==    at 0x693E06A: epoll_ctl (syscall-template.S:84)
==21616==    by 0x529F35B: uv__io_poll (in .../libuv/libuv.so)
==21616==    by 0x528AE62: uv_run (in .../libuv/libuv.so)
[...]
==21616==  Address 0x1ffeffc8ec is on thread 1's stack
==21616==  in frame JuliaLang#1, created by uv__io_poll (???:)

We only initialise e.events and e.data.fd, meaning half of
e.data (the 32 bits not covered by the 4-byte `fd`) is
uninitialised.

PR-URL: libuv#1996
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@vtjnash vtjnash closed this as completed Aug 25, 2020
vtjnash pushed a commit that referenced this issue Jul 20, 2021
@zhaozg @santigimeno
macos: fix memleaks in uv__get_cpu_speed
d2482ae 
ERROR: LeakSanitizer: detected memory leaks

```
Direct leak of 432 byte(s) in 9 object(s) allocated from:
    #0 0x1062eedc2 in __sanitizer_mz_calloc+0x92 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x46dc2)
    #1 0x7fff20171eb6 in _malloc_zone_calloc+0x3a (libsystem_malloc.dylib:x86_64+0x1beb6)
    #2 0x7fff203ac180 in _CFRuntimeCreateInstance+0x124 (CoreFoundation:x86_64h+0x4180)
    #3 0x7fff203ab906 in __CFStringCreateImmutableFunnel3+0x84d (CoreFoundation:x86_64h+0x3906)
    #4 0x7fff203ab0a1 in CFStringCreateWithCString+0x48 (CoreFoundation:x86_64h+0x30a1)
    #5 0x1056f63e1 in uv__get_cpu_speed darwin.c:267
    #6 0x1056f491e in uv_cpu_info darwin.c:338
```

PR-URL: libuv#3098
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vtjnash @tkelman