Backport win,tty fixes for Windows systems #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4736c31. I.e. revert the revert.
PR-URL: libuv#2501 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net> Reviewed-By: Jameson Nash <vtjnash+github@gmail.com> (cherry picked from commit fd2ce38)
This was referenced Jul 9, 2020
This code already had special handling for decoding utf-8 characters correctly for the UCS-2 conhost (trailing incomplete bytes and characters > 0xFFFF). Rather than trying to duplicate that, we can simply delete the duplicate code-path and selectively disable the parts that do not apply. PR-URL: libuv#1965 Ref: JuliaLang/julia#27267 Co-authored-by: Mustafa M. <mus-m@outlook.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> (cherry picked from commit 3016fbc)
PR-URL: libuv#1884 Co-authored-by: Bert Belder <bertbelder@gmail.com> Co-authored-by: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net> (cherry picked from commit 73ca4ac)
PR-URL: libuv#1884 Refs: libuv#1874 Co-authored-by: Bert Belder <bertbelder@gmail.com> Co-authored-by: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <s@saghul.net> (cherry picked from commit 288a067)
musm
force-pushed
the
julia-uv2-1.29.1-win
branch
from
f14b0cb
to
0549c35
Compare
|
The last two commits are not necessary, but I think they can't hurt to add. I'm happy to remove them if desired. |
|
@vtjnash What do think about this, Is this ok to merge or do you have bigger concerns? I'd like to also get in libuv#2910 eventually when that get's merged upstream. |
|
Would be great to get this merged. |
|
merging in a few days sans objections |
|
It looks like I previously either authored or reviewed each of these, so I guess I'm on board. |
|
merge commit / squash and merge / rebase and merge? I'm guessing rebase and merge? |
|
That'd be fine, and probably clearest in the history log |
|
Fantastic, thanks @musm. I've hit many problems with VT support on windows which really can't be worked around. I think this will sort them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport several patches.
These changes help to enable and support VT sequences on Windows.